Skip to content

Conversation

folkertdev
Copy link
Contributor

Most of the tricky logic of SupportedArchitectureTest is now in the trait, making it a lot easier, and shorter, to define new variants. That should make the x86 work a lot simpler.

best reviewed commit-by-commit I think.

cc @madhav-madhusoodanan

@rustbot
Copy link
Collaborator

rustbot commented Sep 7, 2025

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@sayantn
Copy link
Contributor

sayantn commented Sep 9, 2025

LGTM, cc @madhav-madhusoodanan waiting for your confirmation as you have been working on intrinsic-test

@madhav-madhusoodanan
Copy link
Contributor

madhav-madhusoodanan commented Sep 9, 2025

Really useful commits @folkertdev, particularly moving print_results_c and removing the IntrinsicDefinition trait, and placing the arch-specific constants back in configs so that they don't have to be moved around.

Looks good to me too.

@folkertdev folkertdev added this pull request to the merge queue Sep 9, 2025
Merged via the queue into rust-lang:master with commit f48e68d Sep 9, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants