Skip to content

Conversation

a4lg
Copy link
Contributor

@a4lg a4lg commented Sep 11, 2025

This instruction is incorrectly categorized as the same one as aes64ks1i and aes64ks2 (that should require zkne || zknd but currently require zkne && zknd) but aes64im only requires the Zknd extension.

This commit fixes the category of this intrinsic (lowering the requirements from the Rust perspective but it does not actually lower it from the RISC-V perspective).

@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2025

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This instruction is incorrectly categorized as the same one as
`aes64ks1i` and `aes64ks2` (that should require `zkne || zknd` but
currently require `zkne && zknd`) but `aes64im` only requires
the Zknd extension.

This commit fixes the category of this intrinsic (lowering the
requirements from the Rust perspective but it does not actually lower
it from the RISC-V perspective).
@a4lg a4lg force-pushed the riscv-aes64im-lower-requirements branch from fdd8e55 to 7996cc1 Compare September 11, 2025 06:42
@a4lg a4lg changed the title RISC-V: Lower requirements of aes64im RISC-V: "Lower" requirements of aes64im Sep 11, 2025
@sayantn sayantn added this pull request to the merge queue Sep 11, 2025
Merged via the queue into rust-lang:master with commit a173bb2 Sep 11, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants