Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRC32 detection to arm32 #830

Merged
merged 1 commit into from Dec 2, 2019
Merged

Conversation

@makotokato
Copy link
Contributor

makotokato commented Nov 30, 2019

Cortex-A53 etc has 32-bit mode, and it can use crc32 instruction sets even if 32-bit (A32 mode) and CPU is supported. So we should add crc32 detection for arm32.

armv8 has 32-bit mode, but it can use crc32 instruction sets even if 32-bit.
@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Nov 30, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg gnzlbg merged commit edc3f23 into rust-lang:master Dec 2, 2019
5 of 29 checks passed
5 of 29 checks passed
Check Style
Details
Build Documentation
Details
Automatic intrinsic verification
Details
Env Override
Details
Test (i686-unknown-linux-gnu) Test (i686-unknown-linux-gnu)
Details
Test (x86_64-unknown-linux-gnu) Test (x86_64-unknown-linux-gnu)
Details
Test (x86_64-unknown-linux-gnu-emulated) Test (x86_64-unknown-linux-gnu-emulated)
Details
Test (arm-unknown-linux-gnueabihf) Test (arm-unknown-linux-gnueabihf)
Details
Test (armv7-unknown-linux-gnueabihf) Test (armv7-unknown-linux-gnueabihf)
Details
Test (aarch64-unknown-linux-gnu) Test (aarch64-unknown-linux-gnu)
Details
Test (powerpc64le-unknown-linux-gnu) Test (powerpc64le-unknown-linux-gnu)
Details
Test (mips-unknown-linux-gnu) Test (mips-unknown-linux-gnu)
Details
Test (mips64-unknown-linux-gnuabi64) Test (mips64-unknown-linux-gnuabi64)
Details
Test (mips64el-unknown-linux-gnuabi64) Test (mips64el-unknown-linux-gnuabi64)
Details
Test (s390x-unknown-linux-gnu) Test (s390x-unknown-linux-gnu)
Details
Test (wasm32-unknown-unknown) Test (wasm32-unknown-unknown)
Details
Test (i586-unknown-linux-gnu) Test (i586-unknown-linux-gnu)
Details
Test (x86_64-linux-android) Test (x86_64-linux-android)
Details
Test (arm-linux-androideabi) Test (arm-linux-androideabi)
Details
Test (mipsel-unknown-linux-musl) Test (mipsel-unknown-linux-musl)
Details
Test (aarch64-linux-android) Test (aarch64-linux-android)
Details
Test (nvptx64-nvidia-cuda) Test (nvptx64-nvidia-cuda)
Details
Test (thumbv6m-none-eabi) Test (thumbv6m-none-eabi)
Details
Test (thumbv7m-none-eabi) Test (thumbv7m-none-eabi)
Details
Test (thumbv7em-none-eabi) Test (thumbv7em-none-eabi)
Details
Test (thumbv7em-none-eabihf) Test (thumbv7em-none-eabihf)
Details
Test (x86_64-apple-darwin) Test (x86_64-apple-darwin)
Details
Test (x86_64-pc-windows-msvc) Test (x86_64-pc-windows-msvc)
Details
x86_64-unknown-freebsd Task Summary
Details
@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Dec 2, 2019

Thank you!

@makotokato makotokato deleted the makotokato:aarch32-crc32 branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.