Skip to content

rustc-dev-guide: make Noratrieb member #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2025
Merged

rustc-dev-guide: make Noratrieb member #2000

merged 1 commit into from
Sep 27, 2025

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Sep 27, 2025 •
edited
Loading

@Noratrieb regularly reviews PRs, so adding to the team as recognition of that fact

cc @BoxyUwU

@tshepang
rustc-dev-guide: make Noratrieb member
e1ecabc 
Noratrieb regularly reviews PRs, so adding to the team as recognition of that fact, and to reflect reality
@github-actions GitHub Actions
Copy link

Dry-run check results 

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Team Diffs:
    📝 Editing team 'rust-lang/rustc-dev-guide':
      Adding member 'Noratrieb' with member role

@jieyouxu jieyouxu added needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. needs-team-lead-review This change requires a team/WG/PG lead to review. S-waiting-on-team Status: waiting on team and removed S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. needs-team-lead-review This change requires a team/WG/PG lead to review. S-waiting-on-team Status: waiting on team labels Sep 27, 2025
jieyouxu
jieyouxu approved these changes Sep 27, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nora is already a compiler member so

@jieyouxu jieyouxu added this pull request to the merge queue Sep 27, 2025
Merged via the queue into rust-lang:master with commit d8337b2 Sep 27, 2025
3 checks passed
@tshepang tshepang deleted the patch-2 branch September 27, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

+1 more reviewer

@Noratrieb Noratrieb Noratrieb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tshepang @jieyouxu @Noratrieb