Skip to content

Conversation

rylev
Copy link
Member

@rylev rylev commented Oct 24, 2022

This adds configuration for the pkg-config repo. This largely mirrors the current config on GitHub with addition of granting the rest of the crate-maintainers team maintainer rights.

This will also remove @sdroege's maintainer rights which might not be desired. I'll have to add support for adding individuals to repos if that's a requirement here.

r? @m-ou-se @joshtriplett

@sdroege
Copy link

sdroege commented Oct 24, 2022

This will also remove @sdroege's maintainer rights which might not be desired. I'll have to add support for adding individuals to repos if that's a requirement here.

As long as you make sure someone is actually maintaining the crate, feel free to remove me. I've only taken care of the crate over the last years because nobody else did, and one thing less on my list of things to care for would definitely be an improvement :)

That said, I'm also fine with continuing to help maintaining this crate to share the load a bit if you're all too busy as well

@m-ou-se
Copy link
Member

m-ou-se commented Oct 25, 2022

This will also remove @​sdroege's maintainer rights which might not be desired.

Oh, please leave his rights in tact for now.

@sdroege We can try to take over maintenance if you prefer, but it might not be right away.

@sdroege
Copy link

sdroege commented Oct 25, 2022

Let's keep things as they are for now then, works for me!

@rylev
Copy link
Member Author

rylev commented Oct 25, 2022

Sounds great! I'll need to add support for adding individuals to repos before we can merge this. In the meantime, I'll manually add the crate-maintainers team to the pkg-config repo.

@sdroege
Copy link

sdroege commented Oct 25, 2022

Should I add someone else as owner for pkg-config on crates.io? @joshtriplett, @alexcrichton and I are currently owners.

@m-ou-se
Copy link
Member

m-ou-se commented Oct 25, 2022

@sdroege If you can add rust-lang-owner, that'd be great. :)

@sdroege
Copy link

sdroege commented Oct 25, 2022

Done

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, this will temporarily drop access until we merge the sync team PR in the next few minutes.

@Mark-Simulacrum Mark-Simulacrum merged commit b196b9e into rust-lang:master Oct 26, 2022
@rylev rylev deleted the pkg-config-repo branch October 26, 2022 11:57
@sdroege
Copy link

sdroege commented Oct 28, 2022

@sdroege If you can add rust-lang-owner, that'd be great. :)

Just to make sure, the invite arrived?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants