Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize the Write impl for Vec<u8> to Vec<u8, A> #86

Closed
athre0z opened this issue Mar 7, 2021 · 4 comments
Closed

Generalize the Write impl for Vec<u8> to Vec<u8, A> #86

athre0z opened this issue Mar 7, 2021 · 4 comments

Comments

@athre0z
Copy link

athre0z commented Mar 7, 2021

I'd like to generalize the Write impl for Vec<u8> to Vec<u8, A>. Is there any reason for not doing this? I suspect that this impl might simply have been forgotten because it lives in the io module rather than by the other trait impls for Vec?
@TimDiekmann
Copy link
Member

TimDiekmann commented Mar 7, 2021 •
edited
Loading

Please go ahead, I think I simply forgot to implement it. 🙂

@athre0z athre0z mentioned this issue Mar 7, 2021
Merged
@athre0z
Copy link
Author

athre0z commented Mar 7, 2021

Excellent — I created a PR over at rust-lang/rust#82862!

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Mar 8, 2021
@Dylan-DPC
Rollup merge of rust-lang#82862 - athre0z:generalize-vec-write-impl, …
0b98fa1 
…r=TimDiekmann

Generalize Write impl for Vec<u8> to Vec<u8, A>

As discussed in the [issue tracker for the wg-allocators working group][1], updating this impl for allocator support was most likely just forgotten previously. This PR fixes this.

r? `@TimDiekmann`

[1]: rust-lang/wg-allocators#86
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Mar 8, 2021
@Dylan-DPC
Rollup merge of rust-lang#82862 - athre0z:generalize-vec-write-impl, …
68456f7 
…r=TimDiekmann

Generalize Write impl for Vec<u8> to Vec<u8, A>

As discussed in the [issue tracker for the wg-allocators working group][1], updating this impl for allocator support was most likely just forgotten previously. This PR fixes this.

r? ``@TimDiekmann``

[1]: rust-lang/wg-allocators#86
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Mar 8, 2021
@Dylan-DPC
Rollup merge of rust-lang#82862 - athre0z:generalize-vec-write-impl, …
c0466fa 
…r=TimDiekmann

Generalize Write impl for Vec<u8> to Vec<u8, A>

As discussed in the [issue tracker for the wg-allocators working group][1], updating this impl for allocator support was most likely just forgotten previously. This PR fixes this.

r? ```@TimDiekmann```

[1]: rust-lang/wg-allocators#86
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Mar 8, 2021
@Dylan-DPC
Rollup merge of rust-lang#82862 - athre0z:generalize-vec-write-impl, …
2389278 
…r=TimDiekmann

Generalize Write impl for Vec<u8> to Vec<u8, A>

As discussed in the [issue tracker for the wg-allocators working group][1], updating this impl for allocator support was most likely just forgotten previously. This PR fixes this.

r? ````@TimDiekmann````

[1]: rust-lang/wg-allocators#86
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Mar 8, 2021
@Dylan-DPC
Rollup merge of rust-lang#82862 - athre0z:generalize-vec-write-impl, …
3b0a02a 
…r=TimDiekmann

Generalize Write impl for Vec<u8> to Vec<u8, A>

As discussed in the [issue tracker for the wg-allocators working group][1], updating this impl for allocator support was most likely just forgotten previously. This PR fixes this.

r? `````@TimDiekmann`````

[1]: rust-lang/wg-allocators#86
@athre0z
Copy link
Author

athre0z commented Mar 8, 2021

Aaaand it's merged! I'd like to use this chance to thank you (and everyone else involved with this!) for your work on allocator_api. I think that this gets a lot less attention than it deserves. Particularly for gracefully working with arena allocators, this is super important to have!

@athre0z athre0z closed this as completed Mar 8, 2021
@ChayimFriedman2
Copy link

I think we need to check if we have other forgotten impls. A simple way will be to just remove the default type for A and search for compiler errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@athre0z @TimDiekmann @ChayimFriedman2