-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a status quo story about Barbara's first async playground #94
Add a status quo story about Barbara's first async playground #94
Conversation
[htvsq]: ../how_to_vision/status_quo.md | ||
[cannot be wrong]: ../how_to_vision/comment.md#comment-to-understand-or-improve-not-to-negate-or-dissuade | ||
[trusts the rust compiler]: ./alan_started_trusting_the_rust_compiler_but_then_async.md | ||
[Barbara makes their first steps in async]: ./barbara_makes_their_first_steps_into_async.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is a dead link until #70 is merged
(Edit: oops, I clicked the wrong line when adding this comment. This comment is supposed to be attached to the "trusts the rust compiler" link)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great! I only have some small comments.
= help: to use an async block, remove the `||`: `async {` | ||
``` | ||
|
||
Barbara knows that async are stable and using this nightly feature isn't what |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Barbara knows that async are stable and using this nightly feature isn't what | |
Barbara knows that async isn't stable and using this nightly feature isn't what |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, what I wanted to say is: "Barbara knows that async is stable". Do I have that right?
`Box::pin` (and adjusting the type of the Vec), the code compiles and runs | ||
successfully. | ||
|
||
But even though the run is working correctly, she wishes she had a better idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this point. Barbara got the code working, but has an uneasy feeling about it, since she doesn't fully understand why it's needed.
Thanks for the typo fixes @rylev ! Skimming over the notes made on the hackmd document, here are some things that we talked about adding to the story, but didn't actually make it into this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Left a few small comments.
b354b32
to
60c9593
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the template subheadings optional? I thought we were all using those.
This is a status quo story about Barbara and her first experiences with rust async. It was developed mostly from my personal experiences, plus notes from a group discussion with some folks on a zoom "writing session" organized by Niko.
Of the current open issues, this one most closely matches #46.
This new story here is pretty similar to Barbara makes their first foray into async. Both this story and that story start with Barbara in the same place, but they evolve a bit differently and focus in on different things. My first inclination is to keep both stories, but we can certainly discuss if they are worth merging. We might want to adjust the titles of these a bit to make sure they are sufficiently distinct.
Rendered