Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax type bounds for LeastSquaresSvd family #272

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Relax type bounds for LeastSquaresSvd family #272

merged 1 commit into from
Apr 17, 2021

Conversation

janmarthedal
Copy link
Contributor

Allow for the linear operator and right-hand side to have different array types for least_squares, least_squares_into and least_squares_in_place.

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #272 (a23224f) into master (28c7860) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   89.04%   89.10%   +0.06%     
==========================================
  Files          71       71              
  Lines        3586     3606      +20     
==========================================
+ Hits         3193     3213      +20     
  Misses        393      393              
Impacted Files Coverage Δ
ndarray-linalg/src/least_squares.rs 98.88% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c7860...a23224f. Read the comment docs.

@termoshtt termoshtt self-requested a review April 11, 2021 16:25
@termoshtt termoshtt added this to the 0.14.0 milestone Apr 11, 2021
@termoshtt termoshtt merged commit 4111835 into rust-ndarray:master Apr 17, 2021
@termoshtt
Copy link
Member

This is relevant. Thanks!

termoshtt added a commit that referenced this pull request Apr 17, 2021
@janmarthedal janmarthedal deleted the relax-lstsq-types branch April 18, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants