Drop direct blas-src dependency, update docs for blas integration #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can in theory unchain ourselves from the blas-src version and let the user be responsible for linking in blas in the final product. Update xtest-blas to test this configuration. Update instructions in readme for how to use it.
|
This came up because I was waiting for a blas-src release before pulling the trigger on ndarray 0.15. But we're doing it wrong already, we should just depend on the interface (cblas-sys), and let the end user crate supply the implementation. So then we're never waiting on them. We also should port ourselves to blas-sys when possible so that we are compatible all backend configurations. |
bluss
commented
Mar 25, 2021
| @@ -124,8 +124,6 @@ extern crate std; | |||
| #[cfg(not(feature = "std"))] | |||
| extern crate core as std; | |||
|
|
|||
| #[cfg(feature = "blas")] | |||
| extern crate blas_src; | |||
There was a problem hiding this comment.
This was the main feature in the old solution - when we don't link this, the end user has to.
This flag was not properly used anymore. Replace it with a proper blas test setup in xtest-numeric.
bluss
force-pushed
the
disconnect-blas-dependency
branch
from
a6b82fd
to
5b96f1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can in theory unchain ourselves from the blas-src version and let the
user be responsible for linking in blas in the final product.
Update xtest-blas to test this configuration.
Update instructions in readme for how to use it.
Remove ndarray build.rs file since it was only ever used for testing (and now not used anymore!)
Update xtest-numeric so that it actually tests with/without blas. Now there's a bit of
overlap between xtest-numeric and xtest-blas.
It happens that this fixes #950