Skip to content

Conversation

ethindp
Copy link
Contributor

@ethindp ethindp commented Oct 25, 2021

This commit adds the BGRT as specified in SEC. 5.2.22 of the ACPI specification. The BGRT is
used for notifying OSPM of any boot graphics displayed by firmware during the boot process.

Signed-off-by: Ethin Probst ethindp@protonmail.com

…he ACPI specification v. 6.4

This commit adds the BGRT as specified in [SEC. 5.2.22 of the ACPI specification](https://uefi.org/specs/ACPI/6.4/05_ACPI_Software_Programming_Model/ACPI_Software_Programming_Model.html#boot-graphics-resource-table-bgrt). The BGRT is
used for notifying OSPM of any boot graphics displayed by firmware during the boot process.

Signed-off-by: Ethin Probst <ethindp@protonmail.com>
@ethindp ethindp mentioned this pull request Oct 25, 2021
Copy link
Member

@IsaacWoods IsaacWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Couple of bits here and there, but largely ready.

Could you also run rustfmt over this?

the BGRT and return values of orientation offset.

Signed-off-by: Ethin Probst <ethindp@protonmail.com>
@ethindp ethindp requested a review from IsaacWoods October 26, 2021 14:34
@ethindp
Copy link
Contributor Author

ethindp commented Oct 26, 2021

@IsaacWoods Fixed all of them (I used Vim to write the code for this PR -- I'm finally trying to learn it so I thought it had autoformatted it for me). Thanks for the feedback!

Copy link
Member

@IsaacWoods IsaacWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Edit: I'll publish this at some point in the next week or so, but I don't currently have a machine set up for it.

@IsaacWoods IsaacWoods merged commit 57f6278 into rust-osdev:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants