Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AML: Add minimal CondRefOf support #170

Merged
merged 3 commits into from Apr 16, 2023
Merged

Conversation

rw-vanc
Copy link
Contributor

@rw-vanc rw-vanc commented Mar 24, 2023

CondRefOf takes a source and an optional target, returning True if the source is defined. This first implementation only checks if the Reference source is defined. It will error if a target is given (new error code Unimplemented was added rather than using todo!() which will abort).

@IsaacWoods
Copy link
Member

Great, thanks! In future, it'll be nice to have a TODO comment alongside usages of Unimplemented just to make it more obvious something needs more work - I'll add one for this.

@IsaacWoods IsaacWoods merged commit 2d4f81c into rust-osdev:main Apr 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants