Clean up allocator_api feature #177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I wrote the code for the
allocator_api
feature, I had misunderstood how shared allocator references were to be passed around. For example, I did things like this:This seemed correct at the time, but as I've come to understand the feature, I've learned the correct approach:
The expectation being that allocators will implement
impl Clone for &MyAllocator {}
. This makes it much simpler to have a unified means of passing around allocator references.Additionally, I've removed the reliance on the
slice_ptr_get
feature, as it seems to be mostly stagnant. This has no side effects, and was a one-line change.I recognize that, with changing the public-facing API, this is effectively a set of breaking changes. So when or how this PR gets merged is, as I understand, up to maintainers.