Skip to content

aml: Implement DefOr, DefSubtract and DefLNot opcodes #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2023
Merged

aml: Implement DefOr, DefSubtract and DefLNot opcodes #199

merged 4 commits into from
Oct 6, 2023

Conversation

alnyan
Copy link
Contributor

@alnyan alnyan commented Oct 3, 2023

This PR implements some simple opcodes currently missing, but required for real-hardware function.

IsaacWoods
IsaacWoods requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@IsaacWoods IsaacWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! Always good to get these sorts of opcodes out the way.

Just a few things:

@alnyan
Copy link
Contributor Author

alnyan commented Oct 6, 2023

Yeah, sorry, these were pretty dumb mistakes I made while copy-pasting code 😅

@IsaacWoods
Copy link
Member

No worries; I've made plenty! Thanks!

@IsaacWoods IsaacWoods merged commit 07c31c6 into rust-osdev:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacWoods IsaacWoods IsaacWoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alnyan @IsaacWoods