-
-
Notifications
You must be signed in to change notification settings - Fork 70
Add more resource types for parsing _CRS
packages
#76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more resource types for parsing _CRS
packages
#76
Conversation
- Fixed memory descriptor - Address space descriptor (WORD, DWORD, QWORD) - Extended interrupt descriptor - IRQ format descriptor - DMA format descriptor - IO port descriptor
93d4ae9
to
672a693
Compare
@IsaacWoods I'm not quite done yet, but when you get a chance would you mind taking a look at this and letting me know if I'm on the right track here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thanks for working on this :)
I think the broad strokes of this are on the right tracks. I've left some review comments from my initial reading, but I'm afraid I won't have time this week to sit down and get my head around resource descriptors again to check this properly. I'll let you finish and try to make some time then.
The long-term vision for testing is to flesh out our AML test suite with a bunch of stuff. For this, we'd have a bunch of devices with For now, I'm happy as long as they seem to produce sensible results. You could also either dump the ACPI tables and decompile them using Please ask if anything I've said isn't clear, and I'll try and get back when I can :) |
Thanks for the feedback! I'll work on fixing up the things you've mentioned as soon as I get a chance. |
Thanks for your feedback! I've addressed all your comments from before and I think it's in shape for a proper review now when you get a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this looks good now. Thanks very much!
This PR works toward #51 by adding parsers for several descriptor types found in
_CRS
packages. I basically ran through all the devices that QEMU provided on my machine, and kept adding parsers until it stopped hittingunimplemented!()
blocks. This is what I got. In my OS it parses all theBuffer
type CRS entries provided by QEMU.With this, you can parse many Current Resource Settings blocks with code like this:
I checked and this appears to merge cleanly against #75 with only minor changes, so it shouldn't be any trouble to merge this either before or after v2.