Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the bootloader has a feature named `binary`, enable it #43

Merged
merged 5 commits into from Jul 19, 2019

Conversation

@phil-opp
Copy link
Member

commented Jul 18, 2019

This allows the bootloader to define dependencies that only apply to the main.rs (not the lib.rs), in order to reduce compile times. See rust-lang/cargo#1982 (comment) for more information.

If the bootloader has a feature named `binary`, enable it
This allows the bootloader to define dependencies that only apply to the main.rs (not the lib.rs), in order to reduce compile times. See rust-lang/cargo#1982 (comment) for more information.

@phil-opp phil-opp requested a review from 64 Jul 18, 2019

phil-opp added some commits Jul 18, 2019

Pass `--bin` argument when building bootloader
This allows the bootloader to use the `required-features` configuration. Without the `--bin` argument cargo just omits all binaries with unsatisfied required features, so that an unrelated 'no bootloader executable found' error would occur.
Improve error message on build failure
Only print stderr if it's not empty. Stderr is always empty when running without `--quiet` because we then inherit stderr from the shell.

@phil-opp phil-opp force-pushed the binary-feature branch from 04a424e to a718354 Jul 18, 2019

@64

64 approved these changes Jul 18, 2019

Copy link
Contributor

left a comment

LGTM

@phil-opp phil-opp merged commit bffeb83 into master Jul 19, 2019

8 checks passed

rust-osdev.bootimage Build #20190718.10 succeeded
Details
rust-osdev.bootimage (Build linux) Build linux succeeded
Details
rust-osdev.bootimage (Build mac) Build mac succeeded
Details
rust-osdev.bootimage (Build windows) Build windows succeeded
Details
rust-osdev.bootimage (Check Formatting linux) Check Formatting linux succeeded
Details
rust-osdev.bootimage (Test linux) Test linux succeeded
Details
rust-osdev.bootimage (Test mac) Test mac succeeded
Details
rust-osdev.bootimage (Test windows) Test windows succeeded
Details

@bors bors bot deleted the binary-feature branch Jul 19, 2019

phil-opp added a commit that referenced this pull request Jul 19, 2019

@phil-opp

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2019

Published as version 0.7.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.