Skip to content

Conversation

phil-opp
Copy link
Member

This allows the bootloader to define dependencies that only apply to the main.rs (not the lib.rs), in order to reduce compile times. See rust-lang/cargo#1982 (comment) for more information.

This allows the bootloader to define dependencies that only apply to the main.rs (not the lib.rs), in order to reduce compile times. See rust-lang/cargo#1982 (comment) for more information.
@phil-opp phil-opp requested a review from 64 July 18, 2019 09:07
phil-opp added 3 commits July 18, 2019 11:34
This allows the bootloader to use the `required-features` configuration. Without the `--bin` argument cargo just omits all binaries with unsatisfied required features, so that an unrelated 'no bootloader executable found' error would occur.
Only print stderr if it's not empty. Stderr is always empty when running without `--quiet` because we then inherit stderr from the shell.
Copy link
Contributor

@64 64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-opp phil-opp merged commit bffeb83 into master Jul 19, 2019
@bors bors bot deleted the binary-feature branch July 19, 2019 09:01
phil-opp added a commit that referenced this pull request Jul 19, 2019
@phil-opp
Copy link
Member Author

Published as version 0.7.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants