Set empty RUSTFLAGS to ensure that no .cargo/config applies#51
Merged
Conversation
Without the `RUSTFLAGS` environment variable set, cargo looks at `.cargo/config` files in all parent directories. Such a file can contain a `build.rustflags` key that would then be applied to the bootloader build too. Since some rustflags can break the build (e.g. `-C target-cpu=native`), we should prevent that. Creating a `cargo/.config` file with an empty `build.rustflags` key in the bootloader repository does not suffice for fixing this because cargo unifies arrays with the values defined in parent directories. So the only way to ensure that no rustflags are passed is to set the RUSTFLAGS environment variable to the empty string, exploiting the fact that it takes precedence over any `build.rustflags` key.
The 10.13 image was removed by Azure and no longer builds.
Member
Author
|
Released as version 0.7.9. |
MiscStuff839
pushed a commit
to MiscStuff839/bootimage-wasm
that referenced
this pull request
Nov 16, 2025
Set empty RUSTFLAGS to ensure that no .cargo/config applies
MiscStuff839
pushed a commit
to MiscStuff839/bootimage-wasm
that referenced
this pull request
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the
RUSTFLAGSenvironment variable set, cargo looks at.cargo/configfiles in all parent directories. Such a file can contain abuild.rustflagskey that would then be applied to the bootloader build too. Since some rustflags can break the build (e.g.-C target-cpu=native), we should prevent that.Creating a
cargo/.configfile with an emptybuild.rustflagskey in the bootloader repository does not suffice for fixing this because cargo unifies arrays with the values defined in parent directories. So the only way to ensure that no rustflags are passed is to set the RUSTFLAGS environment variable to the empty string, exploiting the fact that it takes precedence over anybuild.rustflagskey.Fixes phil-opp/blog_os#770