Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate os_bootinfo 0.3.0 as a submodule (with some changes) #23

Merged
merged 2 commits into from
Aug 17, 2018
Merged

Integrate os_bootinfo 0.3.0 as a submodule (with some changes) #23

merged 2 commits into from
Aug 17, 2018

Conversation

phil-opp
Copy link
Member

  • Remove VERSION constant: The kernel can no longer have a separate dependency on os_bootinfo, so it is guaranteed that the bootinfo versions match.
  • Implement the From trait to convert between the frame range types of bootinfo and x86_64.

@phil-opp
Integrate os_bootinfo 0.3.0 as a submodule (with some changes)
926219f 
- Remove VERSION constant: The kernel can no longer have a separate dependency on os_bootinfo, so it is guaranteed that the bootinfo versions match.
- Implement the From trait to convert between the frame range types of bootinfo and x86_64.
@phil-opp
Copy link
Member Author

@lachlansneff Does this fix nebulet?

@phil-opp phil-opp mentioned this pull request Aug 17, 2018
Open
@lachlansneff
Copy link
Contributor

This looks good. Until the upstream bootloader supports packaging, I'll still be using a custom fork, but this is a good step in that direction.

@phil-opp
Copy link
Member Author

Ok, thanks for the review!

@phil-opp phil-opp merged commit c5617fd into master Aug 17, 2018
@phil-opp phil-opp deleted the integrate_os_bootinfo branch August 17, 2018 15:19
@phil-opp
Copy link
Member Author

Published as 0.3.0

Nickforall pushed a commit to Nickforall/bootloader that referenced this pull request Dec 17, 2018
@phil-opp @Nickforall
Integrate os_bootinfo 0.3.0 as a submodule (with some changes) (rust-…
8cc7dca 
…osdev#23)

- Remove VERSION constant: The kernel can no longer have a separate dependency on os_bootinfo, so it is guaranteed that the bootinfo versions match.
- Implement the From trait to convert between the frame range types of bootinfo and x86_64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-opp @lachlansneff