Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings from Clippy #336

Merged
merged 7 commits into from
Jan 27, 2023
Merged

Fix warnings from Clippy #336

merged 7 commits into from
Jan 27, 2023

Conversation

asensio-project
Copy link
Contributor

Hello,

This PR fixes some warnings from Clippy.
It isn't a major change, it only changes the way of how are written some things.

Thanks!

phil-opp
phil-opp reviewed Jan 27, 2023
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks all good to me, except for the Default implementation.

common/src/serial.rs Outdated Show resolved Hide resolved
@asensio-project
Copy link
Contributor Author

The checks are passing. And there is no warning from Clippy.

phil-opp
phil-opp approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phil-opp phil-opp merged commit 85c3536 into rust-osdev:main Jan 27, 2023
@phil-opp phil-opp mentioned this pull request Mar 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asensio-project @phil-opp