Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 320x200 256 color VGA video mode #35

Merged
merged 6 commits into from Nov 25, 2018

Conversation

@phil-opp
Copy link
Member

commented Nov 25, 2018

No description provided.

@phil-opp phil-opp force-pushed the vga-video-mode branch from 2eaa907 to 7735f4d Nov 25, 2018
@phil-opp

This comment has been minimized.

Copy link
Member Author

commented Nov 25, 2018

bors r+

bors bot added a commit that referenced this pull request Nov 25, 2018
Merge #35
35: Add support for 320x200 256 color VGA video mode  r=phil-opp a=phil-opp



Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
src/video_mode/vga_320x200.s Show resolved Hide resolved
src/video_mode/vga_text_80x25.s Show resolved Hide resolved
@phil-opp

This comment has been minimized.

Copy link
Member Author

commented Nov 25, 2018

@bjorn3 Good catch, thank you!

bors r-

@bors

This comment has been minimized.

Copy link
Contributor

commented Nov 25, 2018

Canceled

@bjorn3
bjorn3 approved these changes Nov 25, 2018
@phil-opp

This comment has been minimized.

Copy link
Member Author

commented Nov 25, 2018

@bjorn3 Thanks for the review!

bors r+

bors bot added a commit that referenced this pull request Nov 25, 2018
Merge #35
35: Add support for 320x200 256 color VGA video mode  r=phil-opp a=phil-opp



Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Nov 25, 2018

@bors bors bot merged commit 23772c0 into master Nov 25, 2018
3 checks passed
3 checks passed
bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@phil-opp phil-opp deleted the vga-video-mode branch Nov 25, 2018
@phil-opp

This comment has been minimized.

Copy link
Member Author

commented Nov 25, 2018

Published as version 0.3.7

@phil-opp phil-opp referenced this pull request Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.