Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid mapping to zero page caused by off-by-one bug #424

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

phil-opp
Copy link
Member

@phil-opp phil-opp commented Feb 16, 2024

The zero_end bound is exclusive, but we treat the end_page as inclusive. So when zero_end is page-aligned, we allocate one additional bss page. If this page was already mapped to some other segment, we remap it to a page with random content.

This is the same bug as #362.

Fixes phil-opp/blog_os#1297

The `zero_end` bound is exclusive, but we treat the `end_page` as inclusive. So when `zero_end` is page-aligned, we allocate one additional bss page. If this page was already mapped to some other segment, we remap it to a page with random content.

This is the same bug as #362.
This seems like a good indicator for bugs in the mapping code.

This reverts PR #423 and commit f317b0d.
@phil-opp phil-opp merged commit 419bbdf into v0.9-base Feb 16, 2024
14 checks passed
@phil-opp phil-opp deleted the v0.9-fixes branch February 16, 2024 14:57
@phil-opp
Copy link
Member Author

Published as v0.9.27 🚀

@vinc
Copy link

vinc commented Feb 19, 2024

Hi @phil-opp, thanks for the recent updates on the v0.9 branch! 🚀

There's a little issue with this last one, it should have removed the unused imports Translate and TranslateResult that were introduced by the previous one (#423) because they are now causing a warning during compilation.

Would you like a quick PR fixing that?

@phil-opp
Copy link
Member Author

Ah, I missed that. Yes, a PR against the v0.9-base branch would be appreciated!

@vinc
Copy link

vinc commented Feb 28, 2024

Great, working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants