string parsing followup: introduce better fitting error type + raise MSRV #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
cstring-follow-up
branch
2 times, most recently
from
1540b64 to
4e23697
Compare
phip1611
changed the title
phip1611
force-pushed
the
cstring-follow-up
branch
from
91b5c91 to
c280585
Compare
This is required because of the usage of `core::ffi::CStr::from_bytes_until_nul`
phip1611
force-pushed
the
cstring-follow-up
branch
from
c280585 to
9ee178a
Compare
This aligns the name with the inner error. In the codebase, however, we use "null". NUL often refers to the ANSI character `0`/NUL and null or NULL to a zero pointer, i.e., to nothing. For now, we keep null everywhere except for the StringError::MissingNul.
phip1611
force-pushed
the
cstring-follow-up
branch
from
f012064 to
62ffedc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #172.
A new
StringErrorerror type was introduced and the MSRV is bumped from1.68to1.69.FYI: Ping @A0lson