rsdp: add the validate_checksum to rsdp #64
Conversation
| pub fn checksum(&self) -> u8 { | ||
| self.checksum | ||
| /// Validation of the RSDPv2 extended checksum | ||
| pub fn checksum_is_valid(&self) -> bool { |
There was a problem hiding this comment.
Only added a validation of the RSDPv2 extended checksum for the RsdpV2Tag. Should we have a RSDPv1 checksum validation and extended checksum validation function for the RsdpV2Tag?
There was a problem hiding this comment.
No, with the later revisions, it is correct to check that the entire structure (including both the checksum and extended checksum fields) sums to 0, and so we only need the one function.
There was a problem hiding this comment.
Yeah, the checksum of the ACPI 1.0 fields is still valid in the a RSDPv2 structure, but I don't know of a reason for a user to only check this. If we do find a reason to include it, it shouldn't be hard to add.
| pub fn checksum(&self) -> u8 { | ||
| self.checksum | ||
| /// Validation of the RSDPv2 extended checksum | ||
| pub fn checksum_is_valid(&self) -> bool { |
There was a problem hiding this comment.
No, with the later revisions, it is correct to check that the entire structure (including both the checksum and extended checksum fields) sums to 0, and so we only need the one function.
Add the validate_checksum method to the implementation of the RsdpV1Tag and RsdpV2Tag.
|
Published as multiboot2 v0.9.0 |
Add the validate_checksum method to the implementation of the RsdpV1Tag
and RsdpV2Tag.
CC: @phil-opp @IsaacWoods
Fixes: #63