Add unwrap_io and unwrap_mem convenience methods on Bar #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
commented
Jun 9, 2024
| @@ -7,7 +7,7 @@ description = "Library with types for handling PCI devices" | |||
| categories = ["hardware-support", "no-std"] | |||
| readme = "README.md" | |||
| license = "MIT/Apache-2.0" | |||
| edition = "2018" | |||
| edition = "2021" | |||
There was a problem hiding this comment.
The 2021 edition has TryInto in the prelude. If preferred I can manually import it instead.
mkroening
reviewed
Jun 9, 2024
This makes PCI drivers slightly easier to write. Redox OS has the same methods on it's counterpart to the Bar type of this crate.
bjorn3
changed the title
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes PCI drivers slightly easier to write. Redox OS has the same methods on it's counterpart to the Bar type of this crate.