Remove the function_exists method of ConfigRegionAccess #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't used anywhere and pci_types can implement it itself if it needs to by checking if the vendor and device id fields are both 0xFFFF. Fixes rust-osdev#14
|
This is a breaking change, so it will have to merged as part of pci_types 0.10 or later. |
|
Yeah, when I extracted this library from my kernel I think this existed because I was worried about a rogue PCI enumeration routine causing an out-of-bounds access in the MCFG or something, but this seems like a sensible change now. I'm planning to collect all the breaking changes together and release a new version with them all. |
IsaacWoods
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't used anywhere and pci_types can implement it itself if it needs to by checking if the vendor and device id fields are both 0xFFFF.
Fixes #14