Add method to decode UCS-2 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, will merge after doc is added |
|
@GabrielMajeri Added a doc comment and bumped the version. I would appreciate if you would publish the new version to crates.io once this is merged, so I can bump the dependency in rust-osdev/uefi-rs#113. I've also added myself as an author. If you do not find this appropriate, I would be happy to rework that commit to leave as is. |
|
Looks fine now, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method to decode UCS-2 into UTF-8 code-points in a buffer. This buffer can then be used to construct a
&str.Also updates the crate to the newest edition.