Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How this works? #25

Closed
gil0mendes opened this issue Sep 21, 2018 · 3 comments
Closed

How this works? #25

gil0mendes opened this issue Sep 21, 2018 · 3 comments
Assignees
Labels

Comments

@gil0mendes
Copy link
Contributor

I know, this shouldn't be used for this kind of things but I'm intrigued how this works without having the whole BootServices structure completed?

uefi-rs: https://d.pr/i/Fq5fkC
Specification: https://d.pr/i/ci9x0L

@HadrienG2
Copy link
Contributor

HadrienG2 commented Sep 22, 2018

I think it doesn't work yet, and weird things will happen if you try to call copy_mem(), as you'll actually end up calling set_watchdog_timer() instead.

If you look at the part of the table which is closer to the spec, you'll see that it uses usizes for unsupported APIs, which is a better approach.

@GabrielMajeri
Copy link
Collaborator

@gil0mendes we use usize to leave space for unimplemented functions, but in this case I think I've forgotten to leave in the padding. And the lack of tests for these functions meant this would've gone undetected for a while.

Fixed in 035d96b. Thanks for your bug report.

@gil0mendes
Copy link
Contributor Author

Thanks for the clarification, now I'm in peace 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants