Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xtask: Allow unions in uefi-raw #1018

Merged
merged 1 commit into from Dec 6, 2023
Merged

xtask: Allow unions in uefi-raw #1018

merged 1 commit into from Dec 6, 2023

Conversation

nicholasbishop
Copy link
Contributor

The checks are mostly the same as for structs, so refactor a bit to share code between the checks.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
xtask: Allow unions in uefi-raw
9fd1cba 
The checks are mostly the same as for structs, so refactor a bit to share code
between the checks.
phip1611
phip1611 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@phip1611 phip1611 added this pull request to the merge queue Dec 6, 2023
Merged via the queue into rust-osdev:main with commit 6db6d99 Dec 6, 2023
12 checks passed
@nicholasbishop nicholasbishop deleted the bishop-allow-union branch December 7, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicholasbishop @phip1611