uefi-services: Use "dep:" syntax #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
requested changes
Mar 16, 2024
Use `dep:` for the optional `qemu-exit` dependency. This avoids implicitly adding a useless `qemu-exit` feature to the crate. Doc: https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies
nicholasbishop
force-pushed
the
bishop-implicit-feature
branch
from
c55c26c to
1177448
Compare
phip1611
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
dep:for the optionalqemu-exitdependency. This avoids implicitly adding a uselessqemu-exitfeature to the crate.Doc: https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies
Checklist