Fix some new lints/warnings #1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-fix-dead-warn
branch
from
df26763 to
fc79308
Compare
nicholasbishop
changed the title
phip1611
approved these changes
Mar 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The merge train pipeline fails: https://github.com/rust-osdev/uefi-rs/actions/runs/8417467100/job/23045999267 @nicholasbishop - unfortunately, I do not have time to look into this. |
The nightly compiler has started warning about imports that aren't needed due to existing glob imports, including in the prelude. Remove all of these unnecessary imports.
|
Looks like the nightly compiler now warns if you import something by name that was already imported by glob. So for example: use uefi::prelude::*;
use uefi::table::boot::BootServices; // warning: the item `BootServices` is already importedIn a couple places this was also happening due to the prelude glob, e.g. an import of Pushed another commit to fix all those cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist