uefi-test-runner: speed up ploting of sierpinski triangle by updating changed pixel only #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffLi01
changed the title
|
Interesting. May you tell us a little about the background how/where you noticed the slow performance? Are you running everything inside a QEMU without accelerator? Looks cool and sensible - thanks! |
Yes, I executed the example within QEMU on my laptop, and it took several tens of seconds for the outline to appear. |
… changed pixel only Signed-off-by: Jeff Li <lijinfeng01@ieisystem.com>
|
I ran it locally on my machine. A notable performance improvement - thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only one pixel needs to be updated, there is no need to transfer the entire buffer. After drawing the background in advance, you only need to update each pixel that requires it.