uefi: Make FileSystem work with both variants of ScopedProtocol #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help ease the API transition, make `FileSystem::new` accept either variant of ScopedProtocol.
nicholasbishop
force-pushed
the
bishop-fs-generic
branch
from
5cea5c9 to
02e5f0e
Compare
phip1611
reviewed
Aug 25, 2024
| @@ -17,6 +17,8 @@ how to integrate the `uefi` crate into them. | |||
| - `allocator::init` and `allocator::exit_boot_services` have been | |||
| deprecated. These functions are now no-ops. The allocator now internally uses | |||
| the global system table. | |||
| - `FileSystem::new` now accepts `boot::ScopedProtocol` in addition to | |||
There was a problem hiding this comment.
No, this should not break compilation because it accepts either one. There should not be any code that used to work that is now rejected.
There was a problem hiding this comment.
ah right, you adapted the constructor.
phip1611
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help ease the API transition, make
FileSystem::newaccept either variant of ScopedProtocol.Checklist