Skip to content

Move PAGE_SIZE to uefi-raw and reexport from uefi boot modules #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2024
Merged

Move PAGE_SIZE to uefi-raw and reexport from uefi boot modules #1383

merged 2 commits into from
Aug 30, 2024

Conversation

nicholasbishop
Copy link
Member

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop nicholasbishop mentioned this pull request Aug 28, 2024
Closed
2 tasks
@nicholasbishop
Copy link
Member Author

This causes the new package job to fail: https://github.com/rust-osdev/uefi-rs/actions/runs/10599537539/job/29374817387?pr=1383

It didn't occur to me that cargo package would try to build uefi against the current released versions of stuff rather than the local workspace. I'm not sure if it's possible to configure it differently? We might need to drop that job if there isn't a workaround.

nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request Aug 29, 2024
@nicholasbishop
Revert "ci: check if crate can be packaged"
91b245e 
This reverts commit fc5c0a9.

When `cargo package` builds `uefi`, it does so with dependencies from
crates.io. That causes a problem if `uefi` depends on some not-yet-released API
changes in `uefi-raw` or `uefi-macros`. For example, see:
rust-osdev#1383 (comment)

I couldn't find a way to force it to use local deps, so revert the job for now.
@nicholasbishop nicholasbishop mentioned this pull request Aug 29, 2024
Merged
2 tasks
@phip1611 phip1611 force-pushed the bishop-raw-page-size branch from 5fcca41 to 98da390 Compare August 30, 2024 05:16
@phip1611 phip1611 enabled auto-merge August 30, 2024 05:16
@phip1611 phip1611 added this pull request to the merge queue Aug 30, 2024
Merged via the queue into rust-osdev:main with commit e7b3118 Aug 30, 2024
14 checks passed
@nicholasbishop nicholasbishop deleted the bishop-raw-page-size branch August 30, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611