Skip to content

Fix unused warnings if log-debugcon is not enabled #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix unused warnings if log-debugcon is not enabled #1389

merged 2 commits into from
Sep 3, 2024

Conversation

nicholasbishop
Copy link
Member

Also update xtask so that the --feature-permutations test catches this.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
uefi: Fix unused warnings if log-debugcon is not enabled
eeaba6f
@nicholasbishop
xtask: Add support for log-debugcon feature
8c51602 
This ensures `cargo xtask build --feature-permutations` tests `log-debugcon`
both enabled and disabled.
@phip1611 phip1611 added this pull request to the merge queue Sep 3, 2024
Merged via the queue into rust-osdev:main with commit 8d0937a Sep 3, 2024
14 checks passed
@nicholasbishop nicholasbishop deleted the bishop-debugcon-fixes branch September 3, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611