Added output to show what is happening. Made run command load any fi…

[rexlunae]

…rmware files from the path, allowing the use of unified firmware files such as those installed by Ubuntu's ovmf package.

[rexlunae]

In getting the build script to work on Ubuntu, I discovered that the OVMF package that Ubuntu installs is different from whatever you are using, in that it has a single file. Because the existing build script assumes the existence of exactly two firmware files, I couldn't make it work unmodified. I think it makes more sense to allow any number of firmware files. With this change, all I have to do is make a soft link from the share directory to the build directory, and it works. It should still work with the separate OVMF_CODE.fd and OVMF_VARS.fd files, so this is simply adding functionality. Also, I added output showing what the script is doing, because I found this helpful in figuring out how and why the build was failing.

[GabrielMajeri]

First of all, according to this page, Ubuntu's ovmf does come with two files, at least since xenial.

The issue here is that os.listdir returns files in arbitrary order, and we cannot be sure OVMF_CODE.fd comes before OVMF_VARS.fd. And if the first doesn't come in the command line before the latter, it won't boot. Sorting them might help.

I have no issue with the part of the pull request which outputs the commands.

---

I'd rather ask users of distros which haven't yet updated their packages, to use kraxel's repo, since that way they will at least have a fairly new version of UEFI, with fewer bugs.

[rexlunae]

Well, I definitely only got one file when I installed the package. But I'm on a Bionic, which is quite a bit newer than Xenial. But if the order of loading matters, this isn't a good approach, even if sorting would coincidentally make it work. So, I'd say disregard the pull request for now. I don't properly know how qemu's mechanism works for loading firmware.

…

On Sat, Jun 9, 2018, 22:37 Gabriel Majeri ***@***.***> wrote: First of all, according to this page <https://packages.ubuntu.com/xenial/all/ovmf/filelist>, Ubuntu's ovmf does come with two files, at least since xenial. The issue here is that os.listdir returns files in arbitrary order, and we cannot be sure OVMF_CODE.fd comes before OVMF_VARS.fd. And if the first doesn't come in the command line before the latter, it won't boot. Sorting them might help. ------------------------------ I'd rather ask users of distros which haven't yet updated their packages, to use kraxel's repo <https://www.kraxel.org/repos/jenkins/edk2/>, since that way they will at least have a fairly new version of UEFI, with fewer bugs. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGah9sFZ9sfdOTeCZzF4GKRcqB-KHKWKks5t7LCrgaJpZM4UhdgJ> .

[GabrielMajeri]

• If you're Bionic, try to reinstall the package, or check to see if the /usr/share/OVMF directory contains the files (not /usr/share/ovmf, that's the old one - unix paths are case sensitive).

• 7e9dbb7 adds command line printing for the build script.

• fc7f85d adds a link to Gerd Hoffmann's repository of built QEMU binaries.