Skip to content

uefi: Clean up error docs in media protocols #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

nicholasbishop
Copy link
Member

  • Fix the path to the status values -- uefi::status::* does not exist, it should be Status::*.
  • Drop EFI_ prefix to match the actual Status constants.
  • Use doc links so that incorrect names are caught by rustdoc.
  • Reformat some errors to a single line for consistency.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

* Fix the path to the status values -- `uefi::status::*` does not exist, it should
  be `Status::*`.
* Drop `EFI_` prefix to match the actual `Status` constants.
* Use doc links so that incorrect names are caught by rustdoc.
* Reformat some errors to a single line for consistency.
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phip1611 phip1611 added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit a2fd496 Mar 10, 2025
19 checks passed
@phip1611 phip1611 deleted the bishop-clean-up-err-docs branch March 10, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants