xtask: improved error output for "wrong" repr #1742
Merged
+35
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to better understand why something fails.
phip1611
force-pushed
the
improve-cargo-xtask-v2
branch
from
f882a9d to
b5919ff
Compare
phip1611
commented
Aug 16, 2025
| "forbidden use of enum; use the `newtype_enum!` macro instead" | ||
| ), | ||
| Self::ForbiddenItemKind(_) => write!(f, "forbidden type of item"), | ||
| Self::ForbiddenRepr(reprs) => { |
There was a problem hiding this comment.
all arms are the same as before, except for this arm
nicholasbishop
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncontroversial part from #1741
Checklist