Skip to content

Conversation

zdivelbiss
Copy link

Motivation

My previously merged pull request's code comments had various spelling errors, phrasing inconsistencies, and generally bothered me with their quality—I've gone back and edited them so they match the quality I'd expect from a public crate.

Changes

All I've edited are code comments that were made for code in my previous pull request.

@GabrielMajeri
Copy link
Collaborator

Thanks for these fixes! Unfortunately, CI has failed due to nightly changes. I've opened #194 to fix them, but it seems it fails to build due to a linker error. We'll have to wait until a newer Rust nightly version is released.

@GabrielMajeri
Copy link
Collaborator

@avirule CI should be fine now. Could you rebase on the latest master?

@GabrielMajeri
Copy link
Collaborator

Thanks!

@GabrielMajeri GabrielMajeri merged commit 88a852f into rust-osdev:master Feb 1, 2021
@zdivelbiss zdivelbiss deleted the avirule-comments-cleanup branch February 16, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants