Repository navigation
Add support for getting/setting variables - #245
Merged
Merged
Conversation
Added three methods to `RuntimeServices`: `get_variable_size`, `get_variable`, and `set_variable`. Also added a test for these methods. There's a TODO comment about testing runtime services after existing boot services, but I'm not sure how best to structure that change, so for now I've added the new test prior to exiting boot services.
nicholasbishop
force-pushed
the
bishop-add-vars-2
branch
from
June 30, 2021 17:17
e9f988a to
863362d
Compare
Collaborator
|
Thanks for implementing these methods!
Yeah, we haven't figured out that part yet, but it's good to have the tests no matter the environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added three methods to
RuntimeServices:get_variable_size,get_variable,and
set_variable.Also added a test for these methods. There's a TODO comment about testing
runtime services after existing boot services, but I'm not sure how best to
structure that change, so for now I've added the new test prior to exiting
boot services.