Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for getting/setting variables #245

Merged
merged 1 commit into from Jul 5, 2021

Conversation

nicholasbishop
Copy link
Contributor

@nicholasbishop nicholasbishop commented Jun 30, 2021

Added three methods to RuntimeServices: get_variable_size, get_variable,
and set_variable.

Also added a test for these methods. There's a TODO comment about testing
runtime services after existing boot services, but I'm not sure how best to
structure that change, so for now I've added the new test prior to exiting
boot services.

Added three methods to `RuntimeServices`: `get_variable_size`, `get_variable`,
and `set_variable`.

Also added a test for these methods. There's a TODO comment about testing
runtime services after existing boot services, but I'm not sure how best to
structure that change, so for now I've added the new test prior to exiting
boot services.
@GabrielMajeri
Copy link
Collaborator

Thanks for implementing these methods!

There's a TODO comment about testing runtime services after existing boot services, but I'm not sure how best to structure that change, so for now I've added the new test prior to exiting
boot services.

Yeah, we haven't figured out that part yet, but it's good to have the tests no matter the environment.

@GabrielMajeri GabrielMajeri merged commit 48e958d into rust-osdev:master Jul 5, 2021
@nicholasbishop nicholasbishop deleted the bishop-add-vars-2 branch December 12, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants