Skip to content

Add support for getting/setting variables - #245

Merged
GabrielMajeri merged 1 commit into
rust-osdev:masterfrom
nicholasbishop:bishop-add-vars-2
Jul 5, 2021
Merged

GabrielMajeri merged 1 commit into
rust-osdev:masterfrom
nicholasbishop:bishop-add-vars-2

Conversation

@nicholasbishop

@nicholasbishop nicholasbishop commented Jun 30, 2021 •

Copy link
Copy Markdown
Member

Added three methods to RuntimeServices: get_variable_size, get_variable,
and set_variable.

Also added a test for these methods. There's a TODO comment about testing
runtime services after existing boot services, but I'm not sure how best to
structure that change, so for now I've added the new test prior to exiting
boot services.

Added three methods to `RuntimeServices`: `get_variable_size`, `get_variable`,
and `set_variable`.

Also added a test for these methods. There's a TODO comment about testing
runtime services after existing boot services, but I'm not sure how best to
structure that change, so for now I've added the new test prior to exiting
boot services.
@GabrielMajeri

Copy link
Copy Markdown
Collaborator

Thanks for implementing these methods!

There's a TODO comment about testing runtime services after existing boot services, but I'm not sure how best to structure that change, so for now I've added the new test prior to exiting
boot services.

Yeah, we haven't figured out that part yet, but it's good to have the tests no matter the environment.

@GabrielMajeri
GabrielMajeri merged commit 48e958d into rust-osdev:master Jul 5, 2021
@nicholasbishop
nicholasbishop deleted the bishop-add-vars-2 branch December 12, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants