device path: add constants for all subtypes #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constants are grouped and prefixed by their associated `DeviceType`. Also changed `DeviceSubType` to not use `newtype_enum` because many of the values have multiple names, so the `newtype_enum` implementation of `Debug` doesn't work properly and generates warnings.
nicholasbishop
force-pushed
the
bishop-device-path-subtypes
branch
from
cf58949 to
4497d38
Compare
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constants are grouped and prefixed by their associated
DeviceType.Also changed
DeviceSubTypeto not usenewtype_enumbecause many of thevalues have multiple names, so the
newtype_enumimplementation ofDebugdoesn't work properly and generates warnings.