Skip to content

Conversation

nicholasbishop
Copy link
Member

This method uses the get_next_variable_name function of RuntimeServices to get each variable name and vendor GUID.

Copy link
Collaborator

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few minor fixes we could make!

@nicholasbishop nicholasbishop force-pushed the bishop-var-keys-1 branch 2 times, most recently from c5c56fe to 4506436 Compare July 29, 2021 23:38
Copy link
Collaborator

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase on the latest master?

- Added the usual derives.
- Added some docstring backticks to make `cargo doc` happy (otherwise it thinks
  `[uN]` is a link).
This method uses the `get_next_variable_name` function of `RuntimeServices` to
get each variable name and vendor GUID.
@nicholasbishop
Copy link
Member Author

Could you rebase on the latest master?

done

@GabrielMajeri GabrielMajeri merged commit 45c38a1 into rust-osdev:master Jul 31, 2021
@nicholasbishop nicholasbishop deleted the bishop-var-keys-1 branch July 31, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants