Better fmt::Debug for Time struct + fmt::Display
#256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
changed the title
GabrielMajeri
approved these changes
Jul 31, 2021
|
Thanks for improving this structure! |
GabrielMajeri
changed the title
fmt::Debug for Time struct + fmt::Display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! The current
fmt::Debugimpl for theTimestruct didn't included leading zeroes, which is a bit odd. I optimized the implementation.fmt::Displaywas completely missing,Current debug-format looks like:
Time: 2021-07-13 21:14:46.000000000, Timezone=unspecified, Daylight=(empty)and current display-format looks like this:
Time: 2021-07-14 07:00:37.000 (local)(orTime: 2021-07-14 07:00:37.000 UTC+2)I tested it inside my QEMU setup.
Furthermore I changed the debug formatting for the time zone and the daylight fields of a Time struct a bit. The current approach was strange, because for example, users got a weird number for the Timezone without explanation, that this number is the time zone.
What do you think?