device path: add header struct #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All device paths start with the same header containing type, subtype, and length. Move these fields into a struct and use the struct in the two existing device path types, `DevicePath` and `AcpiDevicePath`. This also fixes the missing `length` field in `AcpiDevicePath` since it uses the header type now. The `header` fields in `DevicePath` and `AcpiDevicePath` are not public because it's generally unsafe to modify the values since they determine how the rest of the data in the node is interpreted.
GabrielMajeri
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All device paths start with the same header containing type, subtype, and
length. Move these fields into a struct and use the struct in the two existing
device path types,
DevicePathandAcpiDevicePath.This also fixes the missing
lengthfield inAcpiDevicePathsince it usesthe header type now.
The
headerfields inDevicePathandAcpiDevicePathare not publicbecause it's generally unsafe to modify the values since they determine how
the rest of the data in the node is interpreted.