Improve clippy linting in build.py and CI
#319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features are checked against the current package, which by default is detected by the CWD. This means that if you are in the test runner, enabling the "exts" feature doesn't work because that package doesn't have such a feature, only the uefi packages does. So, as with the `build.py test` command, set the manifest path to the uefi crate so that this command does the right thing regardless of the CWD. Also changed "--all" to "--workspace", since the former is deprecated.
As with the CI step that runs "build.py test", this makes it easier to keep the two in sync. Previously the CI was only linting the uefi package, now it will match build.py's behavior and lint the whole workspace.
nicholasbishop
force-pushed
the
bishop-better-clippy
branch
from
0cd9777 to
1520192
Compare
GabrielMajeri
approved these changes
Dec 11, 2021
GabrielMajeri
changed the title
build.py and CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI only lints the uefi package but with all features enabled, while build.py lints all packages but with no features enabled. Change build.py to lint all packages with a subset of features enabled (all the uefi features that enable more code), and change the CI to just run the build.py clippy command so that the two stay in sync.
Also fixed a few clippy lints in the test runner.