Skip to content

build.py: deny warnings when running clippy #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2021
Merged

build.py: deny warnings when running clippy #324

merged 2 commits into from
Dec 12, 2021

Conversation

nicholasbishop
Copy link
Member

This will make the CI fail if any regular compiler warnings occur.

@nicholasbishop
build.py: deny warnings when running clippy
04178a5 
This will make the CI fail if any regular compiler warnings occur.
@nicholasbishop
Copy link
Member Author

This should help to catch warnings like this in the CI: #320 (comment)

GabrielMajeri
GabrielMajeri approved these changes Dec 12, 2021
View reviewed changes
Copy link
Collaborator

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good way to improve code quality and prevent future missed warnings.

@GabrielMajeri GabrielMajeri changed the title build.py: deny warnings when running clippy build.py: deny warnings when running clippy Dec 12, 2021
@GabrielMajeri GabrielMajeri merged commit 802ed26 into rust-osdev:master Dec 12, 2021
@nicholasbishop nicholasbishop deleted the bishop-clippy-deny-warning branch December 12, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielMajeri GabrielMajeri GabrielMajeri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @GabrielMajeri