xtask: fix status check at end of VM test #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, maybe a repro of #259? 139 == 0x8b, which I believe means a segfault occurred (signal 11 == 0xb, with I downloaded the ubuntu-20.04 aarch64 ovmf files from https://packages.ubuntu.com/focal/all/qemu-efi-aarch64/download and tested locally, no crash. So most likely this is something that has been fixed in qemu sometime between 4.2 and 6.1. |
nicholasbishop
force-pushed
the
bishop-fix-exit-check
branch
from
1ecb578 to
7f55809
Compare
|
Added in a backports PPA (https://launchpad.net/%7Ecanonical-server/+archive/ubuntu/server-backports/) to get a newer version of qemu, that fixed it. |
nicholasbishop
force-pushed
the
bishop-fix-exit-check
branch
from
7f55809 to
05e7787
Compare
GabrielMajeri
force-pushed
the
bishop-fix-exit-check
branch
from
05e7787 to
bc38dd5
Compare
|
Ah, I tried using GH's built-in rebase but CI is now failing. I think we need some changes now that we also have |
nicholasbishop
force-pushed
the
bishop-fix-exit-check
branch
from
bc38dd5 to
6f40444
Compare
This fixes a segfault on exit. rust-osdev#259
This was accidentally dropped when porting build.py to Rust. On AArch64, check that qemu exits 0, and on x86_64, expect an exit code of 3.
nicholasbishop
force-pushed
the
bishop-fix-exit-check
branch
from
6f40444 to
3a5ad1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally dropped when porting build.py to Rust. On AArch64,
check that qemu exits 0, and on x86_64, expect an exit code of 3.