Fix file info sizes and add tests #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, good catch... it's surprising that no UEFI implementation until now cared to check the header size, or we would've encountered errors 😅 |
The size field in the header was accidentally being initialized to 16. [`mem::size_of_val`][1] returns the size of the *pointed-to* value, so by passing in `&info` instead of `info`, we got the size of the DST fat pointer instead of the dynamically-calculated size of the data itself. [1]: https://doc.rust-lang.org/nightly/core/mem/fn.size_of_val.html
GabrielMajeri
force-pushed
the
bishop-add-file-info-tests-2
branch
from
2c209bc to
85a2c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of this change is adding tests for
FileInfo,FileSystemInfo, andFileSystemVolumeLabel.In doing so I noticed that the
sizefield in the header of the first two was calculated incorrectly in theirnewmethods, so fixed that.And some minor changes to implement Derive and PartialEq on additional types to make the tests easier to write.
(I have some more fixes to make in this area including removing the implicit string conversion, but that will be easier with the tests in place.)