Fix ProtocolsPerHandle internal slice property. #374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation contains a
protocols
slice with a lifetimea
.But
protocols
slice does not live long enough for'a
. It will be freed when theProtocolsPerHandle
struct is dropped.From std doc, ( https://doc.rust-lang.org/nightly/core/slice/fn.from_raw_parts.html )
The current codebase does not use this internal property except the
protocols
getter method. So having an invalid lifetime does not immediately cause undefined behavior but it is safer to fix.Since I'm not a native English speaker, it is very appreciated to fix my English document :)
Thanks!