Enable the clippy::ptr_as_ptr lint #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielMajeri
force-pushed
the
bishop-less-as
branch
from
895eadc to
089cda2
Compare
GabrielMajeri
approved these changes
Apr 23, 2022
`as` conversions are a bit of a blunt hammer, so where possible it's nice to use a more restricted operation. Lint is described here: https://rust-lang.github.io/rust-clippy/master/#ptr_as_ptr
nicholasbishop
force-pushed
the
bishop-less-as
branch
from
089cda2 to
717a8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asconversions are a bit of a blunt hammer, so where possible it'snice to use a more restricted operation.
Lint is described here: https://rust-lang.github.io/rust-clippy/master/#ptr_as_ptr
It would be great to eventually get rid of most
asconversions, but baby steps :)