Create macros for making CStr16 and CStr8 literals
#412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! It looks good overall. Could you also add an entry to the |
|
Got it, will do! |
|
Thanks for the PR! I think this is a very nice ease-of-use improvement to strings. |
|
Alright, that should add both the doc comments and allow for the full UTF-16 range. Thanks for catching that by the way! |
|
There are a few clippy lints that need resolving, otherwise lgtm! |
GabrielMajeri
changed the title
CStr16 and CStr8 literals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly simple, just got annoyed while tinkering with a personal project and thought it might be nice to contribute something to help. Both macros take a string literal and convert it to the respective CStr literal.