Improve entry macro tests #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is supposed to only check how bad arguments are handled, not a bad return type. Change the return type to `Status`.
This function was supposed to be const so that it would produce an error.
It turns out that having all of the entry tests in a single file makes it hard to read the diff when the output changes. Split each entry macro test into its own file to fix this. The `good_entry` function has been removed since it doesn't fail compilation ; this case is already tested by uefi-test-runner anyway.
|
The new test structure looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of the tests that weren't testing what they were supposed to test. Also split up the tests into separate files, turns out it's pretty hard to read diffs of the output when everything is in one file.